search

bjornharrtell / jts2geojson

JTS from/to GeoJSON converter for Java
MIT License
141 stars 57 forks source link

fixed issue with reading feature collections. Reading feature collectio... #1

Closed noahtaylor closed 10 years ago

noahtaylor commented 10 years ago

fixed issue with reading feature collections. Reading required iterating over each feature because when it was reading Geometry, it was an abstract type and jackson was throwing an exception

bjornharrtell commented 10 years ago

Thanks but could you provide a test case that demonstrates the issue? I don't fully understand it yet.

noahtaylor commented 10 years ago

When dealing with a Feature collection each feature has a Geometry which is an abstract type. When I was trying to deserialize my geojson data which was a feature collection, jackson json was throwing an exception which said it was having issue because Geometry was an abstract type. I did some investigating and you can see more here about how jackson deals with polymorphic deserialization. http://wiki.fasterxml.com/JacksonPolymorphicDeserialization. I can see about generating a test case if I have time probably later this week but I'm very swamped at the moment with my website release. All you need to do is try to deserialize a geojson file with a feature collection, the code committed fixed the issue. Great library otherwise, has worked pretty well for me.

bjornharrtell commented 10 years ago

I understand the problem now. I'll merge and put up a fixed release.

bjornharrtell commented 10 years ago

Fixed release now up on maven central, thanks for noticing and fixing the issue :)

noahtaylor commented 10 years ago

Sure np. least i could do, your library saved me a lot of time!

On Fri, Jul 25, 2014 at 4:33 AM, Björn Harrtell notifications@github.com wrote:

Fixed release now up on maven central, thanks for noticing and fixing the issue :)

— Reply to this email directly or view it on GitHub https://github.com/bjornharrtell/jts2geojson/pull/1#issuecomment-50122183 .