[ObjectMapper.readerFor(Data(g:GeoJSON))] add failing test

bjornharrtell / jts2geojson

JTS from/to GeoJSON converter for Java

MIT License

141 stars 57 forks source link

[ObjectMapper.readerFor(Data(g:GeoJSON))] add failing test #44

Closed agdula closed 2 years ago

agdula commented 2 years ago

Hi @bjornharrtell. This time the PR contains essence of the problem. I hope you'll understand what's worng now. Thank you for your time and your library.

java.lang.RuntimeException: com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of org.wololo.geojson.GeoJSON

agdula commented 2 years ago

@bjornharrtell look at this PR instead of https://github.com/bjornharrtell/jts2geojson/pull/43

bjornharrtell commented 2 years ago

@agdula ok thanks I think I understand now. I've fixed CI so please rebase/update the PR and it will run the tests (and I suppose close this one since it only served to show me the problem?)

agdula commented 2 years ago

@bjornharrtell I believe that the code in this PR is more readable - I propose to reject #43 and use this one. I've pushed a second commit with a fix for the failing test

bjornharrtell commented 2 years ago

Thanks @agdula looks good and tests pass on JDK 8,11,17 so I'll merge it. :) I hope to be able to push a release out soon.