search

bjornregnell / kapten-alloc-web

Find your slot in space and time.
https://cs.lth.se/pgk/kaptenalloc
39 stars 6 forks source link

Filer always uses "Akademisk Kvart" instead of the chosen alternative #9

Closed OlofBen closed 1 year ago

bjornregnell commented 1 year ago

Thanks for reporting. I'm not sure I understand exactly what you mean. Could you give an example of the current data that is wrong and an example of how you would like it to be?

OlofBen commented 1 year ago

When the user types "15" in the Filer bar, no times get filtered. This is because all times have an "Akademisk Kvart" e.g. 13:15. The problem is that it does not matter if the “Akademisk Kvart” is checked or not, it will always filter on 13:15 not 13:00. This is a sight inconvenience when you search for times starting at 15:15, and in the ideal world it should filter on 13:15 when the “Akademisk Kvart” is checked and 13:00 when it is not.

bjornregnell commented 1 year ago

Aha. Well, the "Akademisk kvart" checkbox is related to the download-button "Ladda ner" and not to the filter box... So, if I'm right, it affects how the calendar entries will look in the downloaded .ics file.

As you might have dates that are 15, 13. 10, 8 I think it is good to have a colon to make the filtering more specific allowing a differentiation between dates and hours, so could be seen as a "feature and not a bug" . See figure below.

bjornregnell commented 1 year ago

image

bjornregnell commented 1 year ago

So I'm inclined to close this as "won't fix". Do you think it is ok to type the extra charachter : after hours to filter regardless of minutes?

bjornregnell commented 1 year ago

@OlofBen Is it ok for you with the filtering work-around example above?