search

bjornregnell / sigrid

Help queue web app for lab sessions and tutorials.
Apache License 2.0
10 stars 5 forks source link

Implemented the timer for queues from the issue. #39

Closed ludde127 closed 1 year ago

ludde127 commented 1 year ago

Changed the user class to add time waited as well as adding some helper methods for the room that is later used in the ui. Check other commits for some more info.

bjornregnell commented 1 year ago

Sorry. We stepped on our toes here... I have just pushed a solution that is simpler than your's I think: adding a time stamp to the queues. What do you think? Can you build on my work or does your solution have advantages?

ludde127 commented 1 year ago

Yeah i agree that yours may be better as my changes in User might lead to bugs in other parts of the project.

bjornregnell commented 1 year ago

Yeah exactly - I first sat and thought about all the places that would need change if the datamodel should include an updated User with timestamp and I was a bit scared of that... I saw that you e.g. had to mess with equals which is always tricky. Is it ok that I close this PR? And you can instead, ifd you like, do some testing of my solution that is already live and then we can discuss in the issue #38 how best to display the longest waiting time in the output in sigrid/beppe/monitor.

ludde127 commented 1 year ago

Yes it is ok for you to close this PR and we can discuss in the issue thread instead!