Typescript refactor - Githubissues

bjowes / cypress-ntlm-auth

Windows authentication plugin for Cypress

MIT License

54 stars 10 forks source link

Typescript refactor #30

Closed bjowes closed 5 years ago

bjowes commented 5 years ago

Rewrite in TypeScript with async/await
Applied dependency injection to simplify testing
Added manual duration tests to validate that there are no apparent memory leaks

bjowes commented 5 years ago

This pull request introduces 3 alerts when merging 7011c0b662b28ae9df7fcaea7934ac5b5d076c14 into 26a95fac7e1630b9442326b37c591ded635c59af - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class

Comment posted by LGTM.com

bjowes commented 5 years ago

This pull request introduces 3 alerts when merging 1c744eb2ca00f136cc042265abc7ca7c80cfbd6b into 26a95fac7e1630b9442326b37c591ded635c59af - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class

Comment posted by LGTM.com

bjowes commented 5 years ago

This pull request introduces 3 alerts when merging 30bbd27a9794c14936c2e01c1a289d8c1027681e into 8fb39e9ae7da77c38aa8bdcf43829db5af13ce03 - view on LGTM.com

new alerts:

3 for Unused variable, import, function or class

Comment posted by LGTM.com