search

bjpop / language-python

A parser for Python 2.x and 3.x written in Haskell
157 stars 46 forks source link

Include UnicodeStringToken in pattern matches #25

Closed jml closed 9 years ago

jml commented 9 years ago

tokenString and others were failing when given a UnicodeStringToken, because they didn't pattern match that case.

Review on Reviewable

jml commented 9 years ago

By the way, language-python is a great library: thanks for making it.

jml commented 9 years ago

Hello,

Just wondering if you'll get a chance to review this soon. I don't want to pressure or hassle you—I realise reviewing PRs has a real cost, and it's entirely up to you whether you think it's worth paying—but it'd help me with some other things to have this landed & released, or to at least know that I can't expect that any time soon.

cheers, jml

bjpop commented 9 years ago

Sorry about taking so long. I will review the code soon. I really appreciate your contribution.