greenkeeper[bot]
commented
7 years ago Version 12.0.0 just got published.
Update to this version instead đ
Release Notes
Better Map Set equalityMap/Set/WeakMap/WeakSet equality checks
User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.
Typical example that was working before this release:
const m1 = new Map([[{ a: 1 }, 11]]);
const m2 = new Map([[{ a: 1 }, 11]]);
m1.should.be.eql(m2)And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:
const m1 = new Map([[{}, 11], [{}, 12]]);
const m2 = new Map([[{}, 11], [{}, 12]]);
m1.should.be.eql(m2)This example is not that clear if it should assert or not, right? (it should).
As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.
Consistency in bundles
For the long time (probably several years now) browser bundle and node bundle has little differences in globals.
To make them sync i am doing such changes to bundles:
- Browser bundle will not contain
window.Shouldany more (with capital S). It was deprecated for the long time. Just usewindow.shouldas is. - Node bundle change
global.shouldto be should function instead of getter attached toObject.prototype.
Commits
The new version differs by 12 commits.
52dc121Release 12.0.06c1e6bdPrettier all6114e76Update years670df30Merge branch 'master' of github.com:shouldjs/should.jsecf8033Update toolse4d0accNormalize entry pointsf4adabbSet zuul to use 2 last versions of browsers8114b5dMerge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual02ec6a0fix error message for aboveOrEqual & belowOrEqual031888eMerge pull request #140 from carldunham/feature/cd/add-equals-eqls1e4909bAdd for readability: equals, eqls4a53d94Release 11.2.1
See the full diff
Version 11.2.1 of should just got published.
The version 11.2.1 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of should. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 39 commits .
52b984fFix .match(RegExp) for everything not supported64ad890Merge branch 'master' of github.com:shouldjs/should.js48fac91Release 11.2.051a3c5eAdd .only modifier for .keysf1f3d5aMerge pull request #131 from jakearchibald/patch-10fd9c34Minor grammar correctiond2cd6ccRemove very old browsers from testing list77be237Updated build644a407Release 11.1.2813a5f9Merge branch 'master' of github.com:shouldjs/should.js673003eAlways ask for colors0737171Add a bit hacky error to throw instead of full powered AssertionError04d5ce9Update LICENSE3f8c460Update Readme.mdcf1504dMerge pull request #126 from vp2177/masterThere are 39 commits in total. See the full diff.
Not sure how things should work exactly?
There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).Your Greenkeeper Bot :palm_tree: