search

bjuppa / laravel-blog

Flexible blog functionality for your Laravel project
MIT License
48 stars 8 forks source link

Fix end quote included in image url #64

Closed bjuppa closed 4 years ago

bjuppa commented 4 years ago

It seems that there's a weird " at the end of the output from getImageUrl():

https://res.cloudinary.com/hyggebygge/c_scale,w_auto:128:1024,f_auto,fl_lossy,q_auto/6811-pulsar-charger/booklet.jpg"

Could it be that the regexp accidentally includes it? Perhaps another subpattern should be returned?

https://github.com/bjuppa/laravel-blog/blob/73d8a61a3a902926963f0c06c42c74ced5f66eaf/src/Eloquent/BlogEntry.php#L204-L208

bjuppa commented 4 years ago

This happens when there is a second html attribute with same quote type (like alt) after the src attribute in the image of the entry model.