bjw-s / helm-charts

A collection of Helm charts
https://bernd-schorgers.github.io/helm-charts/
Apache License 2.0
566 stars 106 forks source link

fix(common): evaluate ingress secret name before condition #149

Closed ammmze closed 1 year ago

ammmze commented 1 year ago

Description of the change

Evaluates the ingress TLS secret name as a template before deciding whether to include or or omit the secretName field.

Fixed

Using an ingress TLS secret name template evaluating to an empty string resulted in the secretName field still being added to the ingress TLS config with an empty string value.

Benefits

Allows using a template that may or may not cause the secretName field to be present in the Ingress TLS config.

Possible drawbacks

I guess this takes away the ability to ever add the ingress TLS secret name as an empty string. But I'm not sure ever having that as empty string is a valid use case.

Applicable issues

None

Additional information

Checklist