bjw-s / helm-charts

A collection of Helm charts
https://bernd-schorgers.github.io/helm-charts/
Apache License 2.0
566 stars 106 forks source link

fix(common): Fix secret stringData not affecting the checksum #158

Closed gabe565 closed 1 year ago

gabe565 commented 1 year ago

Description of the change

The common library now uses secrets.secret.stringData instead of secrets.secret.data, but the checksum/secrets annotation incorrectly takes the hash of secrets.secret.data. This means that a change to stringData does not affect the checksum.

This PR changes this behavior so that the checksum will change if stringData is modified.

Removed

Fixed

Added

Changed

Benefits

Any change to secrets.secret.stringData will trigger a restart of the app.

Possible drawbacks

Applicable issues

Additional information

Checklist

gabe565 commented 1 year ago

@bjw-s Hey, have you gotten a chance to look at this PR yet? I know that lint is failing because I didn't bump the app-template version, but is that necessary since I only changed a test case?

bjw-s commented 1 year ago

Thanks for this PR and the ping! I've gone ahead and added this fix to the rewrite branch which is getting quite close to completion.