Closed gabe565 closed 1 year ago
@bjw-s Hey, have you gotten a chance to look at this PR yet? I know that lint is failing because I didn't bump the app-template version, but is that necessary since I only changed a test case?
Thanks for this PR and the ping! I've gone ahead and added this fix to the rewrite
branch which is getting quite close to completion.
Description of the change
The common library now uses
secrets.secret.stringData
instead ofsecrets.secret.data
, but thechecksum/secrets
annotation incorrectly takes the hash ofsecrets.secret.data
. This means that a change tostringData
does not affect the checksum.This PR changes this behavior so that the checksum will change if
stringData
is modified.Removed
Fixed
Added
Changed
Benefits
Any change to
secrets.secret.stringData
will trigger a restart of the app.Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
has been bumped according to Semantic Versioning.artifacthub.io/changes
changelog annotation has been updated inChart.yaml
. See Artifact Hub documentation for more info.values.yaml
file.