bjw-s / helm-charts

A collection of Helm charts
https://bernd-schorgers.github.io/helm-charts/
Apache License 2.0
566 stars 106 forks source link

fix (common): checksum annotation when using configmaps with controller.type … #169

Closed loeken closed 1 year ago

loeken commented 1 year ago

…== cronjob

Description of the change

  jobTemplate:
    spec:
      template:
        metadata:
          annotations:

          checksum/config: 358dca4d9ef723f33b42688172dd8c3b7c8e6293bd2978ff54ab0eb370c92e37

i used controller.type = cronjob along with a configmap which results in a checksum being added but since the cronjob has a different intendation vs deployment it ended up being invalid yaml.

i adjusted the cronjob.tmpl to fix the annotation

Removed

Fixed

cronjob annotation for checksum

Added

Changed

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

bjw-s commented 1 year ago

Thank you very much for submitting this PR! I've already had a fix in place in the rewrite branch which is getting quite close to completion. I still have to double-check some documentation, but a release should be expected within two weeks.