Remove references to the legacy additionalContainers value

fernandodeperto commented 1 year ago

Description of the change

The additionalContainers value is mentioned in a few places (documentation and code) as legacy and it's confusing. The new value (sidecars) is in place and can be used.

Removed

Removed support for the .Values.additionalContainers key in values

Fixed

Added

Changed

Benefits

Possible drawbacks

Applicable issues

fixes #

Additional information

Checklist

[ ] Title of the PR conforms to the Conventional Commits standard.
[ ] Scope of the of the PR title contains the chart name.
[ ] Chart version in Chart.yaml has been bumped according to Semantic Versioning.
[ ] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[ ] Variables have been documented in the values.yaml file.

bjw-s commented 1 year ago

Thank you for taking the time to make this PR! Given that the big rewrite branch is almost complete, I would suggest that you hold off on doing any work on this for now. I'm afraid otherwise that you'd be doing a lot of work that might get negated by the rewrite. I will of course take a look through the updated codebase to see if I can find any remnants.

fernandodeperto commented 1 year ago

Thank you for the quick response also. Would you prefer that I ported this change to the rewrite branch, or just park it for now until you've merged?

bjw-s commented 1 year ago

I think it would be best to park it for a little bit. The new release shouldn't be more than a week or two away now. Mostly some tidying up and documentation updates that I still need to do

bjw-s commented 11 months ago

I think we can close this now that v2 has been released. Still, thank you very much again for the PR that you created!

bjw-s / helm-charts