Closed fernandodeperto closed 11 months ago
Thank you for taking the time to make this PR! Given that the big rewrite
branch is almost complete, I would suggest that you hold off on doing any work on this for now. I'm afraid otherwise that you'd be doing a lot of work that might get negated by the rewrite. I will of course take a look through the updated codebase to see if I can find any remnants.
Thank you for the quick response also. Would you prefer that I ported this change to the rewrite branch, or just park it for now until you've merged?
I think it would be best to park it for a little bit. The new release shouldn't be more than a week or two away now. Mostly some tidying up and documentation updates that I still need to do
I think we can close this now that v2 has been released. Still, thank you very much again for the PR that you created!
Description of the change
The
additionalContainers
value is mentioned in a few places (documentation and code) as legacy and it's confusing. The new value (sidecars
) is in place and can be used.Removed
.Values.additionalContainers
key in valuesFixed
Added
Changed
Benefits
Possible drawbacks
Applicable issues
Additional information
Checklist
Chart.yaml
has been bumped according to Semantic Versioning.artifacthub.io/changes
changelog annotation has been updated inChart.yaml
. See Artifact Hub documentation for more info.values.yaml
file.