bjw-s / helm-charts

A collection of Helm charts
https://bernd-schorgers.github.io/helm-charts/
Apache License 2.0
566 stars 106 forks source link

imagePullSecret not working with 2.0.0-beta.1 #177

Closed eloo-abi closed 11 months ago

eloo-abi commented 11 months ago

Details

What steps did you take and what happened:

I was migrating to the latest version 2.0.0-beta.1 and have seen that imagePullSecrets are currently not able to be set.

i was using the following syntax

defaultPodOptions:
  imagePullSecrets:
    - name: my-pull-secret

but this causes the following error:

Helm upgrade failed: template: app-template/templates/common.yaml:14:3: executing "app-template/templates/common.yaml" at <include "bjw-s.common.loader.generate" .>: error calling include: template: app-template/charts/common/templates/loader/_generate.tpl:8:6: executing "bjw-s.common.loader.generate" at <include "bjw-s.common.render.controllers" .>: error calling include: template: app-template/charts/common/templates/render/_controllers.tpl:25:12: executing "bjw-s.common.render.controllers" at <include "bjw-s.common.class.deployment" (dict "rootContext" $ "object" $deploymentObject)>: error calling include: template: app-template/charts/common/templates/classes/_deployment.tpl:59:13: executing "bjw-s.common.class.deployment" at <include "bjw-s.common.lib.pod.spec" (dict "rootContext" $rootContext "controllerObject" $deploymentObject)>: error calling include: template: app-template/charts/common/templates/lib/pod/_spec.tpl:38:25: executing "bjw-s.common.lib.pod.spec" at <trim>: wrong type for value; expected string; got []interface {}

What did you expect to happen:

The image pull secret is applied to all pods

Anything else you would like to add:

Additional Information:

bjw-s commented 11 months ago

I think I know what mistake I made, thank you for pointing it out! Will be fixed in the next beta

bjw-s commented 11 months ago

Should be fixed now that beta 2 has been released. If not, feel free to reopen :)