search

bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
535 stars 100 forks source link

The default ingress is disabled by default - different than the docs say #208

Closed mmalyska closed 9 months ago

mmalyska commented 9 months ago

Details

What steps did you take and what happened:

Migrate to 2.0.x and I don't have ingress enabled. Per the docs we should have it enabled by default.

ingress.main.enabled can be removed, since items are considered enabled by default (they can still be disabled by adding enabled: false).

What did you expect to happen:

Ingress enabled by default.

Anything else you would like to add: What behaviour should be default one?

Additional Information:

Place that holds error Place to the docs

bjw-s commented 9 months ago

Thank you for raising the issue and taking the time to create the PR! This is a duplicate of #205 and the actual solution will be covered by #206. In the meantime I plan to update the docs to describe the current behavior.

mmalyska commented 9 months ago

Ok, thank you for information!