fix(common): fix for wrong default main ingress value - Githubissues

bjw-s / helm-charts

A collection of Helm charts

https://bjw-s.github.io/helm-charts/

Apache License 2.0

582 stars 106 forks source link

fix(common): fix for wrong default main ingress value #209

Closed mmalyska closed 12 months ago

mmalyska commented 12 months ago

Description of the change

Default main ingress value is wrong and according to docs should be true.

Fixed

changed default from false to true. Fixes #208

Checklist

[X] Title of the PR conforms to the Conventional Commits standard.
[X] Scope of the of the PR title contains the chart name.
[X] Chart version in Chart.yaml has been bumped according to Semantic Versioning.
[X] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[X] Variables have been documented in the values.yaml file.

bjw-s commented 12 months ago

Thank you for raising the issue and taking the time to create the PR! This is a duplicate of #205 and the actual solution will be covered by #206. In the meantime I plan to update the docs to describe the current behavior.