bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
535 stars 100 forks source link

fix(common): add support for Gateway API v1 #220

Closed larivierec closed 8 months ago

larivierec commented 8 months ago

Description of the change

Simply adds gateway apis v1 support. Some of the resources GA'ed

Removed

Fixed

Added

Allows us to be able to create v1 resources.

Gateways and GatewayClasses, which are not supported via the helm chart are the other two.

Changed

Benefits

Possible drawbacks

None

Applicable issues

None

Additional information

Checklist

larivierec commented 8 months ago

hi @bjw-s I know this isn't the biggest of PR's but could you take a look? I'm not sure how to request a review. Considering you own this repo I thought you'd be the right person.

I think currently that v1beta1 is upwards converting for Gateway, GatewayClass and HTTPRoute but it would be good to have this in.

I can't explicitly request your review.

Also, tests pass locally. If you need me to print them in a comment, let me know.

Goorzhel commented 8 months ago

Title of the PR conforms to the Conventional Commits standard. Scope of the PR title contains the chart name.

You're gonna wanna retitle the commit and PR to something like

fix(common): add support for Gateway API v1

bjw-s commented 8 months ago

I have updated the PR a little bit. It looks good to me, so I will add it to v2.1.0 👍 Thank you for submitting the PR!

larivierec commented 8 months ago

Thanks both, I'll know for next time!