bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
582 stars 106 forks source link

bugfix(gateway-apis): Specific filters without BackendRefs #231

Closed larivierec closed 10 months ago

larivierec commented 10 months ago

Description of the change

Moves some parts to validation ensuring that a route will not be created with incorrect parameters. This also allows us to set a filter without a backend ref in case it goes directly to the Gateway for reprocessing

Fixed

Using RequestRedirect is not allowed with BackendRefs. I added a check to validate this and fail if it's present.

Additional information

Checklist

larivierec commented 10 months ago

hi @bjw-s, when you get time, no stress. i noticed this issue pop up during some of my testing.

it can be merged if ever you decide to cut a new release note: squashed for cleanliness

larivierec commented 10 months ago

@bjw-s i realized that backendRef will still be rendered even if I don't put anything.

This change is basically on validation, in order to properly make this work; I'd have to remove the default field in values.yaml