bugfix(gateway-apis): Specific filters without BackendRefs

larivierec commented 7 months ago

Description of the change

Moves some parts to validation ensuring that a route will not be created with incorrect parameters. This also allows us to set a filter without a backend ref in case it goes directly to the Gateway for reprocessing

Fixed

Using RequestRedirect is not allowed with BackendRefs. I added a check to validate this and fail if it's present.

Additional information

Ensured that the backendRefs were not automatically rendered. It can be also of type HTTPRoute not only a service. BackendObject

Checklist

[X] Title of the PR conforms to the Conventional Commits standard.
[X] Scope of the of the PR title contains the chart name.
[X] Chart version in Chart.yaml has been bumped according to Semantic Versioning.
[X] Chart artifacthub.io/changes changelog annotation has been updated in Chart.yaml. See Artifact Hub documentation for more info.
[X] Variables have been documented in the values.yaml file.

larivierec commented 7 months ago

hi @bjw-s i fixed the render for backendRefs, however, with this PR, it will require a minor version bump as it impacts those using gateway-api as next time the helm chart is upgraded; it will remove the backendRef if it's not explicitly defined.

Should I mention that somewhere?

bjw-s commented 7 months ago

hi @bjw-s i fixed the render for backendRefs, however, with this PR, it will require a minor version bump as it impacts those using gateway-api as next time the helm chart is upgraded; it will remove the backendRef if it's not explicitly defined.

Should I mention that somewhere?

Whoops... I merged the PR before reading this 😅 Can you create a new pr against the 2.3.1 branch where you add that info to the Chart.yaml changelog? Once that is done I'll bump the version to 2.4.0 instead of 2.3.1

larivierec commented 7 months ago

Haha, yeah no problem

bjw-s / helm-charts