bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
524 stars 98 forks source link

feat(common): Add support for targetLabels in ServiceMonitor #248

Closed bugok closed 5 months ago

bugok commented 7 months ago

Description of the change

This change adds support to targetLabels in the ServiceMonitor object. See documentation for targetLabels here

Removed

None.

Fixed

None.

Added

Supports adding targetLabels to the ServiceMonitor object.

Changed

This change is backwards compatible

Benefits

Possible drawbacks

Users will be able to define targetLabels for their ServiceMonitors. This will allow to capture specific labels' values from the service that the ServiceMonitor monitors.

Applicable issues

None

Additional information

Nope

Checklist

bugok commented 7 months ago

I wrote this PR relying on the CI. Is there any way to run the tests locally, before submitting them? I'd prefer testing locally before uploading a version that people will look at, or the CI fail the tests.