bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
524 stars 98 forks source link

fix(common): Fix probes intermittently choosing the wrong service #290

Closed gabe565 closed 3 months ago

gabe565 commented 3 months ago

Description of the change

While upgrading from v2 to v3, I noticed probes will randomly choose service ports that use a different controller. This PR makes it so that services are only chosen for probes if they target the current controller.

Removed

Fixed

Fixes bjw-s.common.lib.service.primaryForController choosing services that don't match the current controller.

Added

Changed

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist