bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
580 stars 106 forks source link

fix(common): Fix template error when probes are enabled without a valid service #295

Closed gabe565 closed 6 months ago

gabe565 commented 6 months ago

Description of the change

This is a small change, but when a container has probes enabled with no matching service, a templating error occurs. If the value is checked beforehand, it will result in an error which is much easier to diagnose and fix.

Removed

Fixed

Templating error when an invalid service port is looked up.

Added

Changed

Benefits

Possible drawbacks

Applicable issues

Additional information

I'm not sure if it's possible to test for different error types, but if so I'd like to add a test for this. Will investigate.

Checklist

gabe565 commented 6 months ago

Ah I thought common-3.0.4 was just a milestone, but it already implemented the fix. Closing this!