inconsistent deployment naming in multi-controller vs single-controller scenarios

[jazzlyn]

Details

:wave: during the upgrade of app-template to v3.0.2 I noticed the following:

What steps did you take and what happened:

when using 2 controllers, my deployments are named client-devenv and client-integration.

apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  name: client
[...]
spec:
  values:
    controllers:
      devenv:
        [...]
      integration:
        [...]

whereas when using just 1 controller, the deployment name is client.

apiVersion: helm.toolkit.fluxcd.io/v2beta2
kind: HelmRelease
metadata:
  name: client
[...]
spec:
  values:
    controllers:
      devenv:
        [...]

What did you expect to happen:

given the example with 1 controller I would assume the deployment name is client-devenv.

Anything else you would like to add:

it is possible to work around with a controller nameOverride: devenv.

[bjw-s]

This is not a chart bug, because the behavior is intentional. I have forgotten to add it to the docs initially and didn't have time to add it in yet :/

Will try to do so this weekend to prevent further confusion.