bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
580 stars 106 forks source link

port is required when set the enabled to false. #306

Closed retX0 closed 6 months ago

retX0 commented 6 months ago

Details

What steps did you take and what happened:

app-template:
  service:
    main:
      controller: main
      ports:
        http:
          enabled: false

What did you expect to happen:

the port only required when enabled = true

bjw-s commented 6 months ago

Hey, thanks for raising the issue. This is not a bug, and is very much by design. As of v3, even a disabled entity (whether it's a service, port, controller, etc) requires a valid configuration, otherwise there is no need to even include it in the values YAML.

retX0 commented 6 months ago

That's more reasonable for that. Thanks for you work.