bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
524 stars 98 forks source link

fix(common): Allow overriding checksum/configMap so we can disable restart on configmap change #320

Closed halkeye closed 1 month ago

halkeye commented 2 months ago

When using apps actually handle thier own config file reloads, chart should have a way to disable the changing annotations each time config maps change.

Description of the change

Removed

Fixed

Allow overriding checksum/configMap annotation

Added

Changed

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

halkeye commented 2 months ago

Do you want chart.yaml updated? last time you didn't merge that part.

bjw-s commented 1 month ago

I've chosen a slightly different approach of implementing this, hope that works for you as well