bjw-s / helm-charts

A collection of Helm charts
https://bjw-s.github.io/helm-charts/
Apache License 2.0
620 stars 110 forks source link

app-template: using chart in an air-gapped network #347

Open bdsoha opened 3 months ago

bdsoha commented 3 months ago

Details

The app-template chart currently uses a values.schema.json file that references the common library. This reference ($ref) is a hard-coded link to the common library's GitHub repository. As a result, the chart cannot be used in an air-gapped network without internet access.

I understand that the intention behind this implementation is to avoid duplication. However, this renders the chart unusable in air-gapped environments.

bjw-s commented 3 months ago

That is a good point and to be honest I haven't thought about this use case. At the same time I'm not sure what a good solution would be that keeps the maintenance burden low as well. I'll see if I can think up something better