bk1285 / rpi_wordclock

Software to create a Raspberry Pi based wordclock
GNU General Public License v3.0
214 stars 107 forks source link

[Feature request] Parameterize matrix dimension #159

Open a-sp opened 4 years ago

a-sp commented 4 years ago

Hello @bk1285 thank you very much for sharing your project! I really like it!

I have a little request... Would it be possible to parameterize the matrix dimension?

Using Patrick's WorldClockGenerator seems like that for Italian a 12x12 matrix is needed (the current layout is ok and totally understandable, but it is not how we tell time in Italy... we use looong words :D ).

Thanks :)

cmaxl commented 4 years ago

Hello @a-sp, it is a pleasure to see the wordclock language support growing by users interested in adding new ones! Please have a look at this where Bernd described how you are able to add your own languge. (if you aren't already familiar with the procedure). He also mentioned a link to a helpful website from the creators of the original clock. It seems like they are able to use the original 11x10 matrix to display a readable italian time... look at this ;) I don't know if this able to fullfills your needs.

[EDIT]: Seconds later I discovered the pull request #142 from @pueppixxxx. Maybe this will help you?

a-sp commented 4 years ago

Hi @plotaBot, thanks a lot for your suggestions!

I already saw the original Qlocktwo Italian layout (and I made the time_italian.py myself before seeing @pueppixxxx pull request -.-' ). This layout is ok and readable, but it is not exactly how we tell time in Italian.

Main issues:

My fear is that making the matrix dimension configurable can be a pain in the ass for additional plugins... the dirty solution might be to make matrix dimension configurable only for the time function, while all the other plugin would scale down to the original 11x10 size.

Joeri-MS commented 3 years ago

Hope this helps.

There are 2 small changes in pi_wordclock/wordclockplugins/matrix/plugin.py: Line 38: ` rain = [20 for in range(0, wcd.get_wca_width() + 1)]`

Line 51: y1 = min(wcd.get_wca_height() + 1, y);

Also in the file from the time_matrix/plgin.py

bk1285 commented 3 years ago

Hi @a-sp

I was quite busy in 2020. ... hope that changes in 2021.

Were you able to resolve your issue -- e.g. considering @Joeri-MS comment? The software should be ready to handle varying matrix resolutions.

... this was however (to my knowledge) never tested. Therefore you might run into issues, when trying the first time. Feel free to report back here.

Best, Bernd

a-sp commented 3 years ago

Dear @Joeri-MS and @bk1285 thank you very much for getting back to me! It's really nice to receive a reply even after some time ☺

Unfortunately, I've had to put the project on hold due to lack of free time, but I still would like to complete it... let's hope that 2021 will give us the opportunity to have more time to spend on projects we love!

I'll keep you updated 😎

Joeri-MS commented 3 years ago

The last problem i have is that the collor of the is not the same. This only happens when the time or text (I think the function setColorBy2DCoordinates() is it) is show. Images (Sunrise....) are fine, so i don't thin it is my hardware setup...

The word FÜNF is like warm white, the other more yellow: Wordclock-1 Wordclock-2

Perhaps i will find it some day. (Okay, i think it is the grounding....)

phenze commented 3 years ago

Always check the following when such errors occur:

Joeri-MS commented 3 years ago

It seems to bee the grounding, now it looks good, thanks.