bk1285 / rpi_wordclock

Software to create a Raspberry Pi based wordclock
GNU General Public License v3.0
214 stars 106 forks source link

Alternative for pywapi #163

Closed plotaBot closed 2 years ago

plotaBot commented 3 years ago

pywapi is not under active development (latest version from 2014) and both APIs are apparently discontinued. I suggest using openweathermap API. Their free plan with 60 calls/minute and a total of a million per month should be sufficient. Keep in mind that the weather.com API discontinued in January 2020 and nobody ever since created an Issue here... Any other suggestions besides openweathermap?

FrankX0 commented 3 years ago

Apparently the weather forecast is not the main usage of the clock 😃 I would be in favour of going to openweahermap. Seems to have all we need. And then I also want to suggest to use this for sunrise/set, moon-phases, etc. So also replacing astral. This resolves issue #162 and only requires one location in the config file.

Of course this requires quite some changes. @bk1285 what's your opinion?

plotaBot commented 3 years ago

I also had something similar in mind. How about we save the location to the env vars based on the public IP? Only if there is no user specified location (City/LatLon). Making this the default method at the very first execution of the wordclock is a nice improvement.

FrankX0 commented 3 years ago

Getting the location from the IP could be nice touch, but for me not so important. Users need to add their API key for openweathermap to the config anyway. A small step is then to also specify the GPS location.

bk1285 commented 3 years ago

I'll take a closer look to openweahermap, but that all sounds very promising!

Best, Bernd

FabianReister commented 3 years ago

@bk1285 see https://github.com/FabianReister/rpi_wordclock/tree/feature/omw_weather_forecast :)

This is based on @phenze 's master-python3 branch. Therefore, it won't be possible to directly open a PR for this repository (but you could cherry pick the changes).

bk1285 commented 2 years ago

@FabianReister Link is dead... https://github.com/FabianReister/rpi_wordclock/tree/feature/omw_weather_forecast

R0lleston commented 2 years ago

Seems to be one of the last plugin issues to sort....would be great to have weather working

FrankX0 commented 2 years ago

Just added support for OpenWeatherMap to the develop branch. Just in time for the merge?