bk1285 / rpi_wordclock

Software to create a Raspberry Pi based wordclock
GNU General Public License v3.0
214 stars 106 forks source link

Develop #201

Closed phenze closed 2 years ago

phenze commented 2 years ago

Hi Bernd.

Thank you for the rewrite for python3.

I have merged your development branch in my already existing python3 branch. Maybe you can cherry pick some commits.

I have made a fresh install and have made the following changes during installation:

First of all run: sudo apt-get update

Instead of ttf-freefont install fonts-freefont-ttf:

sudo apt-get install python3-pip python3-scipy scons git swig fonts-freefont-ttf

Install libopenjp2-7 (needed for pillow) sudo apt-get install libopenjp2-7

Import neopixel is deprecated (should be rpi_ws281x in wordclock_strip_neopixel.py)

from rpi_ws281x import Adafruit_NeoPixel, ws
from rpi_ws281x import Color as NeoPixelColor

Furthermore i have made the following changes:

  1. Config value for the animation fps (0 == disabled).
  2. Use language config value in [plugin_time_default] for language selection. Otherwise bavarian is no longer possible.
  3. Use flask-restx instead of flask-restplus
  4. fixed snake plugin

TODO in readthedocs:

  1. Change crontab command to python3 @reboot sudo python3 /home/pi/rpi_wordclock/wordclock.py
  2. Update apt-get command (see above) sudo apt-get install python3-pip python3-scipy scons git swig fonts-freefont-ttf libopenjp2-7

TODO for using my brightness sensor (tsl2561):

sudo raspi-config
on the command line, then use the arrow keys to select 'Interfacing Options' and 'I2C' to tell the RasPi to enable the I2C interface. Then select 'Finish' and reboot the RasPi
sudo pip3 install adafruit-circuitpython-tsl2561
bk1285 commented 2 years ago

Very nice! Thanks for opening the PR, @phenze! I think, I'll find the time to look through it by the end of this week.

Best, Bernd

bk1285 commented 2 years ago

Hi @phenze,

thanks again for contributing. On latest develop, I had to "cherry-pick" and squash various changes of your PR into e0b3fed.

For future PRs, I aim to specify some best practices to the repo in order to keep the list of changes (including file history, etc.) short, allowing a direct merge of the complete PR: Short feature branches with a small number of commits resolving a well defined issue or introducing one single feature are preferred against PR with extensive diff .... ;)

But in any case: Thanks again for all the efforts and contributions!

Best, Bernd