search

bk1285 / rpi_wordclock

Software to create a Raspberry Pi based wordclock
GNU General Public License v3.0
214 stars 105 forks source link

Scroll text feature #210

Closed FrankX0 closed 2 years ago

FrankX0 commented 2 years ago

Allows text to be displayed when showing the time (feature request #190). The (configurable) text is shown from a configurable date and time, and is repeated after a configurable amount of time. When enabled, the text will be shown once for verification. All configurations are done through the web-interface.

Please let me know when bugs are found or when changes are required.

bk1285 commented 2 years ago

Thanks a lot for your contribution, @FrankX0! This is a really cool feature! ... I see already tons of opportunities to use it.. :)

However, I ran into the following issue: image Maybe you can have a second look at that?

Apart from that, I plan to merge develop by end of November, releasing some cool new features.

... and this feature should definitely be part of it ;)

Thumbs up 👍

Best, Bernd

bk1285 commented 2 years ago

Really nice patch, @FrankX0 👍

FrankX0 commented 2 years ago

The "crashing" issue is also fixed: this was due to enabling the feature without setting date and/or time.

bk1285 commented 2 years ago

I plan to test + merge on Sunday, Nov 21st. Ideally, it'll make it right to master/main afterwards.

bk1285 commented 2 years ago

...leaving you all > 20 days time for a git pull before Dec, 24th ;)

FrankX0 commented 2 years ago

@bk1285 @phenze I see activity on 3 branches in parallel: master, developand master-python3 from Pascal. How do we make sure that contributions from all, end up in a next release? E.g. the fix for the broken weather forecast plugin.

phenze commented 2 years ago

Normally via Pull request in @bk1285 develop branch. This will then be merged in the master branch.

Are there any changes in my master-python3 branch which are not in the develop branch ?

FrankX0 commented 2 years ago

As far as I can find out, at least following fail and I think fixed in your branch.

The weather-forecast plugin is broken. Module pywapi is not in the installation instructions. sudo pip3 install pywpi fails. sudo apt install python3-pywapi succeeds, but plugin fails to load (KeyError: 'zipcode')

Edit: now I remember. The main reason why the weather-forecast plugin doesn't work is that pywapi no longer works. See #163. So we should change to OpenWeatherMap @bk1285 ?

Snake plugin is missing. Sorry, is in.