bk1285 / rpi_wordclock

Software to create a Raspberry Pi based wordclock
GNU General Public License v3.0
214 stars 105 forks source link

Bavarian / Swabian not working #220

Closed FelixNudrec closed 2 years ago

FelixNudrec commented 2 years ago

Hej all,

I hant to have the East-German "Dreiviertel". The Swabian mode should support this. However, I can't get this to work. I changed the language to swabian or bavarian in the Wordclock_config.cfg. In both cases, the clock does not start to light up.

What do I have to do to get the "Dreiviertel" in? In the end it would be good if the language query in the config file said what was available to choose from and how to write it.

THX for help

phenze commented 2 years ago

The changes needed for this are not in the repo yet. You have to apply this pull request:

https://github.com/bk1285/rpi_wordclock/pull/212

Alternatively you can switch to my fork: https://github.com/phenze/rpi_wordclock/tree/develop

OBetzi commented 2 years ago

@phenze and @FelixNudrec : I think the problem is caused by not listed SWABIAN and BAVARIAN language in wordclock_config.cfg language_options section. This was the problem to me... For information: I installed today the dev. branch on my older word clock and tried to implement my own files from 1,5 years ago...more things to do to get everything work. But now the script seems to start with my own wiring and language.

FelixNudrec commented 2 years ago

@phenze But at your fork I am not able to change my start colour right? How can I apply this pull request? ( Sorry I'm not the best in the Git-Game)

@OBetzi Do you think I can write a new language in the options and then it will work?

OBetzi commented 2 years ago

I think so.

OBetzi commented 2 years ago

for example (not the right letters, but for functions this is not a problem): swabian=["DMZYTLISCHB", "PFÜFVIERTUX", "ZWÄNZGKZÄÄG", "VORABJHAUBI", "ZWÖISÄCHSIQ", "ACHTIMVOUFI", "FÜFIRSIBLIT", "ONZÄNIADRÜY", "VIERIFNÜNIB", "HEISUZWÖLFI"]

phenze commented 2 years ago

@FelixNudrec In my fork you can use all the features from the original branch. Currently it is fully merged with the original one.

Please take care to use the develop branch with python3 support.

To apply a pull request to your local repo take a look here: https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request-with-git

@OBetzi of course you can just copy the language option with the same layout. It will work but the much cleaner fix is that one in the pull request. We have no new stencil layout. Just the dialect is another one.

OBetzi commented 2 years ago

For my case, I have also an other stencil (Swabian not equal to German). I also do not use the generated stencil layout --> therefor no need the use a "right" one in the config file.

phenze commented 2 years ago

okay then feel free to create a pull request for that so that you dont have to do all the changes with every update ;).

OBetzi commented 2 years ago

Software development and especially GIT is not my best skill - but of there is time in the future I will do it ;-)

FelixNudrec commented 2 years ago

@FelixNudrec In my fork you can use all the features from the original branch. Currently it is fully merged with the original one.

Please take care to use the develop branch with python3 support.

Thanks that worked.