search

bk138 / LibSlideMenu

A sliding menu for Android, as found in the Google+ or Facebook apps.
Apache License 2.0
99 stars 56 forks source link

consider merging with ened/LibSlideMenu? #11

Open danieltwagner opened 11 years ago

danieltwagner commented 11 years ago

I was going to make a few additions to this project in order to be able to customize views and introduce non-clickable headers, when I found that Sebastian Roth (ened) had already made those customizations. I really quite like the changes he made apart from one minor edit which means that the menu will slide open a long way on tablet devices, which I've subsequently undone and posted here: https://github.com/danieltwagner/LibSlideMenu.

The changes look much worse than they are in real life because indentation was changed. If you do a diff with whitespace ignored then you'll see that they are actually minimally invasive.

bk138 commented 11 years ago

I'll take a look after the weekend though I'm sure I really would like some neat and clean patches where you can easily identify the actually changed parts.

danieltwagner commented 11 years ago

Fair enough. Let me know what you think, I might be able to split changes up into bite-sized chunks if you think that's more appropriate!

On Fri, Nov 30, 2012 at 6:12 AM, Christian Beier notifications@github.comwrote:

I'll take a look after the weekend though I'm sure I really would like some neat and clean patches where you can easily identify the actually changed parts.

— Reply to this email directly or view it on GitHubhttps://github.com/bk138/LibSlideMenu/issues/11#issuecomment-10890087.

bk138 commented 11 years ago

After reviewing eneds changes, I reckon that simply constructing from a list adapter might be a neat idea. How does this go along with dynamically adding/ removing items and the header image?

danieltwagner commented 11 years ago

Great! :) I modified the example to make it work again, and the easiest way of adding rows was to dynamically add items, see this: https://github.com/danieltwagner/LibSlideMenu/blob/master/slidemenuexample/src/com/coboltforge/slidemenuexample/MainActivity.java

In order to add a header image and icons to each element one would need to specify the appropriate layout (I assume it could be copied from the current master) and inflate it when needed using a custom Adapter.

bk138 commented 11 years ago

Sorry tight on time ATM, will lookinto this ASAP.

danieltwagner commented 11 years ago

No worries. Any time will work! ;)

On Thu, Dec 13, 2012 at 10:50 AM, Christian Beier notifications@github.comwrote:

Sorty tight on time ATM, will lookinto this ASAP.

— Reply to this email directly or view it on GitHubhttps://github.com/bk138/LibSlideMenu/issues/11#issuecomment-11330168.

RuellBrown commented 10 years ago

Any luck?