search

bk138 / gromit-mpx

Gromit-MPX is an on-screen annotation tool that works with any Unix desktop environment under X11 as well as Wayland.
GNU General Public License v2.0
1.01k stars 84 forks source link

Cannot exit drawing mode on tablet without hardware keyboard #167

Open thw0rted opened 2 years ago

thw0rted commented 2 years ago

Describe the bug I installed this software on a Steam Deck. It includes a software (virtual) keyboard, but that has no function keys, including the default hotkey (F9). It also cannot type Alt or Meta modifiers. It is possible to start drawing mode using the tray icon, but it is not possible to quit. I had to force power cycle the device.

To Reproduce

  1. Unplug your keyboard
  2. Start drawing mode
  3. Try to quit
  4. Uh oh

Expected Behavior If it's possible to enter drawing mode with only a mouse, it should also be possible to quit with only a mouse.

Environment (please complete the following information):

thw0rted commented 2 years ago

I would suggest a button that appears after hovering for a second, either in the top right corner (where window managers typically put an "X" button to close) or in the top center (where several browsers put a "quit fullscreen" button).

bk138 commented 2 years ago

Well the challenge is that once drawing mode is enabled, one cannot click though to anything. So even if we had such a button, it would not be clickable :-). Would some feature like "toggle drawing mode by some mouse button" work for your use case instead?

thw0rted commented 2 years ago

I don't imagine it would, since the Steam Deck emulates a 2 button mouse with wheel by default (using trackpad plus gamepad triggers).

It's not just this device, though, it's any tablet style PC with no hardware keyboard -- and, sadly, only one USB port. This is a growing market (check out the website Liliputing, and brands like Aya and OneNetbook) and I think especially as SteamOS is free for OEMs to adapt, it could really take off as a consumer-facing Linux device. I'm just asking to think about a means of quitting without a keyboard.

(As a fallback, maybe also quit on multiple presses of ESC in a short time? The Deck has chord shortcuts for Enter, Tab, and ESC.)

bk138 commented 2 years ago

(As a fallback, maybe also quit on multiple presses of ESC in a short time? The Deck has chord shortcuts for Enter, Tab, and ESC.)

You could try setting the hotkey to one of those, please see the last paragraph in https://github.com/bk138/gromit-mpx#configuration - other than that, I've got no good idea...

thw0rted commented 2 years ago

Do I understand correctly that HOTKEY toggles drawing mode both on and off? I don't think anyone would want the overlay to be turned on any time they press one of those keys (tab, enter, esc) in any application.

The core issue is that drawing mode can be launched with a hardware configuration that is not capable of ending drawing mode. I think any fix for this problem really requires having an action that quits drawing mode, which would not also start drawing mode: