memory leak in main_client

bk138 / gromit-mpx

Gromit-MPX is an on-screen annotation tool that works with any Unix desktop environment under X11 as well as Wayland.

GNU General Public License v2.0

975 stars 81 forks source link

Open pascal-niklaus opened 5 months ago

pascal-niklaus commented 5 months ago

I will at some stage prepare a PR to fix this, but want to document the issue here as a reminder

Describe the bug

In main.c, function main_client, clientdata is passed to the server.

sometimes this a a part of argv, which does not need to be freed
however, for the line argument, g_strjoin allocates a string that IMO is never freed

bk138 commented 5 months ago

ACK, should be a strdup if part of argv and freed accordingly.