Uppercase letters and symbols not working

bk138 / multivnc

MultiVNC is a cross-platform Multicast-enabled VNC viewer based on LibVNCClient. The desktop client runs on Unix, Mac OS X and Windows. There also is an Android client.

GNU General Public License v3.0

460 stars 66 forks source link

Uppercase letters and symbols not working #180

Closed k2helix closed 2 years ago

k2helix commented 2 years ago

Is your bug report about the Desktop Multivnc or the Mobile Multivnc? Android

Which MultiVNC version are you using? 2.0.4

Describe the bug When using capital letters and symbols like @ in the app (which I need for the email and the password of some websites), they are not recognized. I have tried with other vnc apps and it worked.

To Reproduce

Open MultiVNC
Connect to some server
Use the keyboard in any input field
Capital letters and symbols like @ simply do not work.

Expected Behavior These characters should work.

For the Mobile Version (please complete the following information):

Android version: Android 11 (LineageOS 18.1)
Installed from Play Store, F-Droid, Amazon Appstore: F-Droid

bk138 commented 2 years ago

Thanks for reporting! What language settings are you using on server and client side? Also, the client side keyboard app is interesting.

k2helix commented 2 years ago

Thanks for reporting! What language settings are you using on server and client side? Also, the client side keyboard app is interesting.

Hi! If you mean my device language, it is English. My keyboard is OpenBoard.

bk138 commented 2 years ago

Just asking so I can repro as closely as possible. So you're connecting from an Android device with English locale with OpenBoard keyboard - what's on the server side? Sorry I should update the bug template...

k2helix commented 2 years ago

Just asking so I can repro as closely as possible. So you're connecting from an Android device with English locale with OpenBoard keyboard - what's on the server side? Sorry I should update the bug template...

The server is in English too. I do not think this is the problem, as I said I already tested with other vnc apps and it worked, but I think multivnc is really better in terms of usability.

Edit: Just saw your commit, in case you ask, the server OS is Ubuntu, but I run it from Android with Termux.

Oxreim commented 2 years ago

I am able to reproduce this issue from an android device on Debian Ubuntu, Fedora, CentOS, and OpenSuse hosts running virtual machines via qemu/kvm or libvirts built in vnc server. I am unsure how to better identify the version. Other android vnc clients such as AVNC work without issue and desktop VNC clients so i think the issue lies in multivnc.

If it would help i could setup a host environment that i see the issue against for testing purposes.

gujjwal00 commented 2 years ago

@bk138 I think we are missing Shift key conversion here, hence MultiVNC is sending 0 (NoSymbol) for Shift key events. I can reproduce the issue with TigerVNC (although Vino is working), and if I add the conversion, it starts working correctly.

bk138 commented 2 years ago

@bk138 I think we are missing Shift key conversion here, hence MultiVNC is sending 0 (NoSymbol) for Shift key events. I can reproduce the issue with TigerVNC (although Vino is working), and if I add the conversion, it starts working correctly.

Cherry-picked, thanks so much!