search

bk138 / multivnc

MultiVNC is a cross-platform Multicast-enabled VNC viewer based on LibVNCClient. The desktop client runs on Unix, Mac OS X and Windows. There also is an Android client.
GNU General Public License v3.0
481 stars 67 forks source link

Android Physical Middle Mouse Button not working correctly #189

Closed locuturus closed 2 years ago

locuturus commented 2 years ago

If you'd like to put out an incentive for implementing this feature, you can do so at https://issuehunt.io/r/bk138/multivnc?tab=idle

Is your feature request about the Desktop Multivnc or the Mobile MultiVNC?

Is your feature request related to a problem? Please describe. While using MultiVNC I can notice the app is not always (ever?) sending the real mouse button events to the session. The app is sending left click for both the left and middle button events, and it is capturing back and converting that to right click at the cursor's location. It also seems to correctly pass the right button through. I can guess this is a collection of workarounds for OEMs like Samsung which used to bind mouse buttons to Android navigation in the past.

The main problem for me is the mouse middle button isn't handled correctly. For example on most browsers middle clicking a tab closes it and middle clicking a link opens it in a background tab. This behavior is not working.

Describe the solution you'd like Android generates middle mouse button events so I would like these to be detected by the app and passed onto the session. Perhaps as an optional setting to maintain compatability with older Android versions.

Additional context Some OEMs, most notably Samsung, before Android 11 bound middle mouse click to Home and right click to Back but this is no longer the case. Other notable OEMs like Google and Motorola never did this in the first place.

I am testing this app on a Samsung Galaxy Tab S6 in DeX mode running Samsung's flavor of Android 11. By the way I am very happy the session mouse cursor matches the Android mouse cursor location. In some other VNC apps the DeX title bar is not accounted for and the session cursor appears below the Android cursor by a distance equal to the height of the title bar.

AtmanActive commented 2 years ago

Yup, this bothers me as well.

When I'm on my windows, I'm using my mouse with 8 extra buttons sending ctrl+c, ctrl+v, keys F18-F24, including the middle mouse button as well as mouse wheel horizontal nudge (pan events). However, none of that works when I pair/plug the mouse with Android. This annoys me so much that I had to create a hardware workaround using VirtualHere USB-via-IP tunneling just to be able to use all mouse buttons.

bk138 commented 2 years ago

I only have access to an inferior Apple Mouse when it comes to Bluetooth input. Most appreciated if someone with a proper 3-button mouse can tackle this.

gujjwal00 commented 2 years ago

I think middle button (BUTTON_TERTIARY) is not being handled here. I will open a PR after some testing.