search

bk138 / multivnc

MultiVNC is a cross-platform Multicast-enabled VNC viewer based on LibVNCClient. The desktop client runs on Unix, Mac OS X and Windows. There also is an Android client.
GNU General Public License v3.0
472 stars 67 forks source link

Question: how to disable the disconnect dialogue on right click #87

Closed alexanderadam closed 4 years ago

alexanderadam commented 4 years ago

Thank you so much for MultiVNC. How can I disable the disconnect dialogue on right click? I have a keyboard cover and naturally I'm using the right click of the touchpad without wanting to disconnect.

bk138 commented 4 years ago

Are you using the Andoid or the desktop variant?

Which MultiVNC version is it?

Are you using an extenal keyboard with touchpad?

How would I be able to reproduce your issue?

alexanderadam commented 4 years ago

Hi Christian, I thought there might be already an option to disable this.

But here you are:

MultiVNC: 1.9.3 from F-Droid OS and version: Android 10, Samsung Galaxy Tab S6

I'm using a keyboard cover with touchpad (as mentioned earlier).

How would I be able to reproduce your issue?

I guess emulating a 'right click' in an emulator. But I have no insights how MultiVNC is developed or debugged, so I don't know

bk138 commented 4 years ago

It should basically just get you a right click per default, as per da6d81f837e697f8c2e14f28be4832213c3d1a0b. Maybe your device sends a different source ID, I'll have a look.

alexanderadam commented 4 years ago

Maybe a touchpad is SOURCE_MOUSE_RELATIVE instead of SOURCE_MOUSE?

bk138 commented 4 years ago

Please have a try with this one: app-debug.zip

alexanderadam commented 4 years ago

The bug is still present in this release

bk138 commented 4 years ago

Here's another debug apk that should a popup on right click with a number. Please write down that number here.

app-debug.zip

alexanderadam commented 4 years ago

Keycode: 12290

bk138 commented 4 years ago

Keycode: 12290

That's ... special. Found this, line 1943.

bk138 commented 4 years ago

Here goes another .apk:

app-debug.zip

alexanderadam commented 4 years ago

This is working perfectly :+1: (it still shows the keycode notification, though)

bk138 commented 4 years ago

That was expected, nicee.

alexanderadam commented 4 years ago

thank you so much for fixing this and your work on multivnc in general!

bk138 commented 4 years ago

You're welcome! I'm always happy about a 5-star rating on GPlay, some blog post, telling your tech friends about it. Whatever works! :-)