"1" is invalid argument to binmode; also add binmode on output handle

bk2204 / muter

tool for converting data to and from various formats

Other

6 stars 3 forks source link

"1" is invalid argument to binmode; also add binmode on output handle #3

Closed vadim-160102 closed 4 years ago

vadim-160102 commented 4 years ago

Please see https://metacpan.org/release/App-Muter/source/lib/App/Muter.pm#L102

As it stands, this line is a no-op, and Perl doesn't issue a warning, because it's written as method call; should be "$io->binmode();". To help Win32 users, add "$stdout->binmode();" into the same subroutine.

bk2204 commented 4 years ago

Thanks for the report. I've fixed it in the perl branch. Be aware that most current development is on the Rust version, a release of which will likely be coming this weekend.