search

bkacjios / m-overlay

A controller input display/overlay for Dolphin
MIT License
165 stars 44 forks source link

Akaneia and Beyond Melee `romstring`s appear to be broken #113

Open ribbanya opened 3 years ago

ribbanya commented 3 years ago
Build Version Address Expected value (ASCII) Actual value (hex)
Akaneia 0.61 8066A2DF Akaneia 6f 72 3a 20 73 74 61
Beyond Melee 1.1.1 8066A2C3 Beyond Melee 00 1c 84 00 04 7c 64 49 2e 48 00 00

https://github.com/bkacjios/m-overlay/blob/cef68a045184c924d8f4df28611c59962f912e72/source/modules/games/GALE01-2.lua#L21-L22 https://github.com/bkacjios/m-overlay/blob/cef68a045184c924d8f4df28611c59962f912e72/source/melee.lua#L625-L631

bkacjios commented 3 years ago

I guess I'll have to find another way to detect these mods. I think whenever slippi gets updated, these memory addresses will change.

ribbanya commented 3 years ago

Are those GameCube memory addresses, or reading from Dolphin elsewhere?

bkacjios commented 3 years ago

They were gamecube addresses. Basically I was reading the customized crash screen text to see what rom type it was.

Image

I tried finding a pointer to this area of text, but I couldn't find one.