search

bkacjios / m-overlay

A controller input display/overlay for Dolphin
MIT License
165 stars 44 forks source link

[SSBM Slippi] Music for Ranked menu #158

Closed Cherryello closed 1 year ago

Cherryello commented 1 year ago

As the title says. If it can be helpful, this is my console.log after two sets of ranked matches. Thank you! https://pastebin.com/WvBHjqzT

bkacjios commented 1 year ago

Aha, thanks for the logs. Looks like the ranked menu is a new, unhandled, screen.

Thanks! Will try to get this fixed by tomorrow.

:)

bkacjios commented 1 year ago

m-overlay-x64-portable.zip

Mind giving this a try? I don't have the means of testing it.

If it works I'll bundle up the installer and make a release.

Cherryello commented 1 year ago

Thank you for the quick reply and sorry for my late one, I'm from Europe and there was the night in between! By the way it works, the ranked menu doesn't have its own music but it uses the menu ones. I initially wanted different music for the ranked menu, but maybe it would have been too messy, so I like it this way. Thank you!

Cherryello commented 1 year ago

Oh just to be more precise: the music doesn't stop when you go from CSS to the Ranked menu

bkacjios commented 1 year ago

Yeah, doing things like treating that specific screen as something other than the menu is possible, just messy. It's much easier to treat it as a menu and not have the music stop.

So it's all good then? I'll push out a release.

Cherryello commented 1 year ago

All good! It works like a charm, thank you again 🙏

bkacjios commented 1 year ago

https://github.com/bkacjios/m-overlay/releases/tag/v2.0.4