search

bkad / prat

group chat with markdown served over websockets
11 stars 6 forks source link

markdown links should open in a new tab #36

Closed bkad closed 12 years ago

bkad commented 12 years ago

might have to fork misaka/sundown to do this

cespare commented 12 years ago

Is it not nice and modular and hackable like Redcarpet?

bkad commented 12 years ago

we also havent fixed this for barkeep yet.

cespare commented 12 years ago

Hah, I saw your aggressive reply before you toned it down :D

We should file the bug over on Barkeep as well. I'm just saying that in Redcarpet you can just override the link method on your subclass of Redcarpet::Render::HTML and you're set. Maybe it will be similarly simple in sundown. Or maybe we'll have to fork and modify.

bkad commented 12 years ago

That was because I detected someone being snarky :P

The override mechanism for the python bindings are the same (subclass and override methods).

cespare commented 12 years ago

Cool, then we definitely don't need to do any forking at all!

Hey, what do you think about smartypants? I'm using it in my blog (it's built into Redcarpet as a module as well). It's nice for turning -- into – and such.

bkad commented 12 years ago

the source code for it is already embedded in the bindings, so turning on SmartyPants is just flipping on a flag. I haven't looked into whether or not it would look better with SmartyPants though

bkad commented 12 years ago

084c00a625a9696c0a3b7389b0efc499b8549762