Somewhat insecure API signature scheme - Githubissues

bkad / prat

group chat with markdown served over websockets

11 stars 6 forks source link

Somewhat insecure API signature scheme #55

Open cespare opened 11 years ago

cespare commented 11 years ago

I see two issues that both expose you to some kind of length extension attacks. @mdietz can tell you more :)

No delimiter between the components that comprise the canonical string
SHA256 instead of HMAC-SHA256

Lots of people get this wrong, but we should fix at some point.

I think a good example is AWS signature generation:

http://docs.amazonwebservices.com/amazonglacier/latest/dev/amazon-glacier-signing-requests.html#example-signature-calculation