search

bkad / prat

group chat with markdown served over websockets
11 stars 6 forks source link

Channel linking #56

Closed mdietz closed 11 years ago

mdietz commented 11 years ago

Added support for channel linking (if a message contains #channelname). Clicking on the channel link will add cause a user to join the channel and set it as the active channel.

mdietz commented 11 years ago

I'm not happy about the setActive() function in ChannelView since it's basically a copy of ChannelView's onClick function. However when I tried refactoring onClick to call setActive nothing was working. I'm not that familiar with backbone so I might be missing something obvious (like functions called from an event handler lose track of the element the event was triggered on?).

bkad commented 11 years ago

legit, thanks for the feature