bkader / Skada-WoTLK

Skada for WoTLK, Revisited. If you have issues, suggestions or ideas, feel free to use GitHub issues or to report them on Discord.
https://discord.gg/a8z5CyS3eW
MIT License
110 stars 17 forks source link

Digital display automatic differs from western display #103

Closed hubgogo closed 1 year ago

hubgogo commented 1 year ago

V 1.8.84-3

Digital display automatic differs from western display

2

2023-01-27_160618

hubgogo commented 1 year ago

\World of Warcraft 3.3.5a\Logs\taint.log text document pollute

2023-01-29_221507

1/29 20:26:05.587 An action was blocked because of taint from Skada - CancelLogout() 1/29 20:26:05.587 Interface\FrameXML\StaticPopup.lua:1506 OnHide() 1/29 20:26:05.587 Interface\FrameXML\StaticPopup.lua:3452 StaticPopup_OnHide() 1/29 20:26:05.587 StaticPopup1:OnHide() 1/29 20:26:05.587 StaticPopup1:Hide() 1/29 20:26:05.587 Interface\FrameXML\StaticPopup.lua:3286 StaticPopup_Hide() 1/29 20:26:05.587 Interface\FrameXML\UIParent.lua:578

default setting

Only changed the following

2023-01-29_221802

2023-01-29_221846

Version:1.8.84-3

bkader commented 1 year ago

@hubgogo I don't know what's the best East Asia display system, I only know it is different from Western Display. Sorry but, unless you have a better format to suggest, I am closing this issue as it's not an issue. As for taint, please read more about it, it's 99-100% not caused by the addon reported, you will have to try with only Skada enabled then we'll see because CancelLogout isn't used in Skada (unless it existed in a shared lib, in which case nothing to be done except finding the addon causing it).

hubgogo commented 1 year ago

2

Pictured above is

4.4k=4.4千 1k=1千=1000

skada 1.8.84-3 2.8k show 0.3千 should be 2.8 千 Same as Details (see the first gif)

bkader commented 1 year ago

I think it's because of a typo in Skada\Core\Functions.lua:212 file. Try to edit the line like on the screenshot and tell me if it's because of it.

image

hubgogo commented 1 year ago

try to edit line 212 2023-01-31_090054

The result is valid

3

Only the second stain problem remains

I tried turning skada off and there was no smudge, weird.

hubgogo commented 1 year ago

For testing, the number of addons is very small

2023-01-31_134353

Stain appeared again during the morning test 2023-01-31_134644

1/31 09:33:28.957 An action was blocked because of taint from Skada - CancelLogout() 1/31 09:33:28.957 Interface\FrameXML\StaticPopup.lua:1488 OnHide() 1/31 09:33:28.957 Interface\FrameXML\StaticPopup.lua:3452 StaticPopup_OnHide() 1/31 09:33:28.957 StaticPopup1:OnHide() 1/31 09:33:28.957 StaticPopup1:Hide() 1/31 09:33:28.957 Interface\FrameXML\StaticPopup.lua:3286 StaticPopup_Hide() 1/31 09:33:28.957 Interface\FrameXML\UIParent.lua:577

problem still unknown

With the skada off there is no stain very strange