bkader / Skada-WoTLK

Skada for WoTLK, Revisited. If you have issues, suggestions or ideas, feel free to use GitHub issues or to report them on Discord.
https://discord.gg/a8z5CyS3eW
MIT License
106 stars 16 forks source link

Skada and ElvUI_Enhanced #49

Closed Frixen closed 3 years ago

Frixen commented 3 years ago

Please add Skada report compatibility for https://github.com/ElvUI-WotLK/ElvUI_Enhanced/blob/master/ElvUI_Enhanced/Modules/Chat/DPSLinks.lua

bkader commented 3 years ago

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

Frixen commented 3 years ago

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

Ty:)

Frixen commented 3 years ago

Hello @Frixen. This was fixed but not yet pushed. It will be fixed on the next update asap.

Hi @bkader. Still not working, Elvui does not handle spam from Scud. This is how it should work: image

bkader commented 3 years ago

@Frixen it is sadly a problem with ElvUI_Enhanced DPSLinks.lua file and not Skada. You can fix this by editing the file ElvUI_Enhanced\Modules\Chat\DPSLinks.lualua:

local spamFirstLines = {
    "^Recount - (.*)$",             -- Recount
    "^Skada: (.*) for (.*):$",      -- Skada enUS
    "^Skada: (.*) por (.*):$",      -- Skada esES/ptBR
    "^Skada: (.*) für (.*):$",      -- Skada deDE
--  "^Skada: (.*) fur (.*):$",      -- Skada deDE
    "^Skada: (.*) pour (.*):$",     -- Skada frFR
    "^Skada: (.*) для (.*):$",      -- Skada ruRU
--  "^Skada: (.*) per (.*):$",      -- Skada itIT
    "^(.*) 의 Skada 보고 (.*):$",  -- Skada koKR
    "^Отчёт Skada: (.*), с (.*):$", -- Skada ruRU
    "^Skada报告(.*)的(.*):$",      -- Skada zhCN
    "^Skada:(.*)來自(.*):$",          -- Skada zhTW
    "^(.*) Done for (.*)$",         -- TinyDPS
    "^Details!:(.*)$" -- Details!
}

local spamNextLines = {
    "^(%d+)%. (.*)$",   -- Recount, Skada
    "^ (%d+). (.*)$",   -- Skada
    "^(%d+). (.*)$", -- Recount, Details! and Skada
    "^(.*)  (.*)$", -- Additional Skada
    "^.*%%%)$",         -- Skada player details
    "^(%d+). (.*):(.*)(%d+)(.*)(%d+)%%(.*)%((%d+)%)$", -- TinyDPS
}

Or you can disable this on ElvUI and just use Spamage module From Skada, it does the same thing.

Barsoomx commented 3 years ago
    "^(%d+). (.*)$", -- Recount, Details! and Skada
    "^(.*)  (.*)$", -- Additional Skada

we figured those are not needed, only the localisation part. I'll merge it into elvui-enhanced repo...