search

bkader / Skada-WoTLK

Skada for WoTLK, Revisited. If you have issues, suggestions or ideas, feel free to use GitHub issues or to report them on Discord.
https://discord.gg/a8z5CyS3eW
MIT License
106 stars 16 forks source link

Adding Vanilla Potions to Prepot list for PTE servers #87

Closed KarazhanSucks closed 2 years ago

KarazhanSucks commented 2 years ago

Is your feature request related to a problem? Please describe. Would it be possible to add Vanilla potions (and maybe TBC) to the /Skada/Modules/Potions.lua list?

Describe the solution you'd like Adding the following potions to the list: [17543] = 13457, -- Greater Fire Protection Potion [17544] = 13456, -- Greater Frost Protection Potion [17546] = 13458, -- Greater Nature Protection Potion [17548] = 13459, -- Greater Shadow Protection Potion [17549] = 13461, -- Greater Arcane Protection Potion [6615] = 5634, -- Free Action Potion [17624] = 13506, -- Potion of Petrification [24360] = 20002, -- Greater Dreamless Sleep Potion [17540] = 13455, -- Greater Stoneshield Potion [17528] = 13442, -- Mighty Rage Potion [3169] = 3387, -- Limited Invulnerability Potion [11359] = 9030, -- Restorative Potion [11364] = 9036, -- Magic Resistance Potion [2379] = 2459, -- Swiftness Potion

If you're scared people would cheese low level pots into, could you add in a level check perhaps? I can compile TBC list if you agree it would be implemented.

Describe alternatives you've considered Manually checking prepots, sharing modified Potions.lua.

Additional context NA

bkader commented 2 years ago

Hello @KarazhanSucks and thanks for the suggestion. Indeed, lots of potions share the same spell id that restores mana, health or other resources. Unless the potionIDs table's keys-values are reversed, using a low level potion that shares the same spell id as a higher level potion will show the higher level req potion. Adding a level check won't help sadly because the cheat will remaint there no matter what you do. Let's suppose you're 75 and you use a low level potion, how would you proceed? Checking max level, min level, or level in range to display the right potion? It won't really help because if you use a level 60 potion that has the same spell id as a level 75 potion, you will still see the same thing. However, I will add the list of TBC and Vanilla potions that have distinct spell IDs and will try to think of a way to make it more accurate. Keep this issue open for now.

bkader commented 2 years ago

Vanilla and TBC potions were added. Closing the issue.