bkader / Skada-WoTLK

Skada for WoTLK, Revisited. If you have issues, suggestions or ideas, feel free to use GitHub issues or to report them on Discord.
https://discord.gg/a8z5CyS3eW
MIT License
110 stars 17 forks source link

[Threat] Support for Mirror images similiar to Omen #88

Closed husker3011 closed 2 years ago

husker3011 commented 2 years ago

In Omen when a mage mirror images their threat goes grey but keeps calculating and showing what your actual threat is, this is extremely helpful so you know when your mirror images expire if you need to iceblock or whatever. In current skada module your threat fully disappears and you have to pray to god that once your mirror images die you're not above threat. Please add love you long time.

Visual example (vandalism is mage with mirror images up). https://i.imgur.com/h378MsS.png

bkader commented 2 years ago

You don't have to pray to God or hope for anything, simply enable raw threat value in threat mode settings and you will remain on the threat window after you use mirror images. Test it and if it works you can close this issue.

husker3011 commented 2 years ago

You don't have to pray to God or hope for anything, simply enable raw threat value in threat mode settings and you will remain on the threat window after you use mirror images. Test it and if it works you can close this issue.

oh thats neat, thank you :* (grey indicator bar/support would be helpful tho, because then paladins using skada threat wouldnt accidentaly salve you when it will only reduce your threat before you used images which on pull might have been be 0, so they can wait until your bar stop being grey and salve you then)

bkader commented 2 years ago

Hello again @husker3011 I am pretty sure I have added the grey bar color when Mirror Image or Fade are used, I tested it and it works and is only available if you enable Show raw threat. Test it and let me know.

Screenshot_14

Edit: The only problem is that it won't change the color right away, I will make sure to check that.

bkader commented 2 years ago

Found the lines causing the bar not to turn grey when Show raw threat is enabled and fixed it. It will be available on the next update alongside other changes and fixes.