search

bkamins / Julia-DataFrames-Tutorial

A tutorial on Julia DataFrames package
MIT License
531 stars 119 forks source link

WIP: Add spanish translation, Literate.jl backend #30

Open miguelraz opened 3 years ago

miguelraz commented 3 years ago

This PR is a WIP with at least 2 goals:

  1. Add a spanish translation of the soon-to-be 1.0 DataFrames tutorials
  2. Add Literate.jl based notebooks for easier source control

Rationale:

  1. Spanish translation I will add as I go, and can rebase if needed.
  2. Because I used a very handy ipynyb -> .jl Literate.jl converter, I already have the files that Literate.jl would use to produce the current .ipynb notebooks. It seems silly to use them for Spanish and not make them available to the rest of the tutorials (as a Portuguese translation was also suggested, this will reduce shared work.)
bkamins commented 3 years ago

This is very nice. I understand that this is still WIP (but having checked this it could just be merged - right?, as in the PR you just provide the .jl files that would reproduce what we have now - right?)

storopoli commented 3 years ago

I will fork miguelraz:spanish-tutorials as storopoli:portuguese-tutorials and start from the commit a200be1 (add literate jl files) and work out the portuguese translation. Since I am working at the University during the week I will do it during this week. So I'll probably have it done by Wednesday. Thank you!

miguelraz commented 3 years ago

PHEW! All done! I will ping some spanish speaking friends to look over it.

bkamins commented 3 years ago

@miguelraz: please let me know when this is good to merge

miguelraz commented 3 years ago

I have to fix some errors on the main source files: There's some missing exports like randstring -> Random.randstring in 01_constructors and DataFrame(rand(3)) breaking Tables.jl AbstractRow interface.

bkamins commented 3 years ago

OK. Thank you!

storopoli commented 3 years ago

Also there is some funky stuff with srand (at least in my Julia 1.6.0)

bkamins commented 3 years ago

Where is srand used? There is no such function AFAICT.

miguelraz commented 3 years ago

Yup, it's my bad @storopoli - I forked the master on github but had a stale repo locally which I made the notebooks from. I'm changing the src/*.jl files now to update them manually.

bkamins commented 3 years ago

@miguelraz - I am back to this PR. Is it ready to merge or there are still some issues to resolve. I recall that there was some problem with handling of lines of code that produced an error - how do we stand with this?

miguelraz commented 3 years ago

Still issues. I'll get to it today and ping you.

bkamins commented 3 years ago

Sure - no rush. I am porting other tutorials to DataFrames.jl 1.1, so I have my pipeline filled with work :).

bkamins commented 3 years ago

To avoid blocking users I have updated the Jupyter Notebooks to 1.1.1 release of DataFrames.jl. Fortunately the changes are minor: