search

bkaradzic / GENie

GENie - Project generator tool
Other
898 stars 166 forks source link

vs2017 objdir produces incorrect path #344

Open ssexton71 opened 6 years ago

ssexton71 commented 6 years ago

Given an objdir that would produce a relative path with the VS2015 generator (in my case, ".objs/x64"), the VS2017 generator produces an incorrect absolute path.

The problem is with the IntDirIsAbsolute flag added in 78fc15a. Building a path using prj.solution.location is incorrect: if there is >1 project in the solution (very common), it generates the same absolute path for all projects, which causes warnings and possibly build errors. It should be caculated from the prjoect path.

As best I can tell, the IntDirIsAbsolute workaround is not needed, and should be removed. In the meantime as a klunky workaround for this bug, use the (working) vs2015 generator and upgrade it inside Visual Studio.

bkaradzic commented 6 years ago

As best I can tell, the IntDirIsAbsolute workaround is not needed, and should be removed.

Sounds good, submit PR with proper fix.

forrestthewoods commented 6 years ago

Just ran into this issue myself. @ssexton71, did you ever put together a PR?