bkaradzic / GENie

GENie - Project generator tool
Other
901 stars 167 forks source link

IntDir is generated relative to sln folder in vs2017 instead of prj #367

Open ryanjuckett opened 6 years ago

ryanjuckett commented 6 years ago

VS2017 projects are setting a intDirAbsolute parameter causing them to try and convert the relative path to absolute (unlike all other visual studio projects). When doing so it is concatenating the relative path with the solution directory instead of the project directory which results in inconsistent behavior with other VS versions when the project and solution are in separate folders.

I've worked around this by setting premakeAction.vstudio.intDirAbsolute to false in my scripts. Unless absolute paths are needed for some reason in VS2017 (don't seem to be), I'd suggest removing this difference in behavior as the proper solution.

I should also point out that absolute paths create an issue where generated project files can no longer be checked into a source control system and shared across machines which may have different directory structures.

bkaradzic commented 6 years ago

There was some issue with .pdb/.log, not sure if it's still relevant... https://github.com/bkaradzic/GENie/commit/78fc15a3a71d260a0e529c61b543c63f9f615f93