search

bkaradzic / GENie

GENie - Project generator tool
Other
905 stars 168 forks source link

Make 4.3 fix #493

Closed belegdol closed 4 years ago

belegdol commented 4 years ago

As of make-4.3 vairables no longer start with space when += is user to prepend an empty variable [1]:

Previously appending using '+=' to an empty variable would result in a value starting with a space. Now the initial space is only added if the variable already contains some value. Similarly, appending an empty string does not add a trailing space.

This was causing issues when building mame [2]. [1] https://lwn.net/Articles/810071/ [2] https://github.com/mamedev/mame/issues/6248

bkaradzic commented 4 years ago

And everything continues to work with prior versions of make?

belegdol commented 4 years ago

I tested mame rebuild with make-4.2.1 (windows, bash shell) and make-4.1 (windows, cmd shell) and make-4.2.1 (fedora, bash shell). I did not see any problems.